Replace Forms API with plain SWT in workspace dialogs#3881
Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Replace Forms API with plain SWT in workspace dialogs#3881vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
Author
|
Note to myself: Need to build aggregator with this change to see recent workspace in action, configuration scope is not shared in runtime Eclipse. |
Contributor
|
Note that notes to yourself along with drafts generate emails for everyone. Please consider completing work before publicizing it as a draft. |
Contributor
Author
Sure, I will try to handle more developments via branches on my forks. |
Contributor
vogella
force-pushed
the
replace-forms-api-workspace-dialogs
branch
2 times, most recently
from
4394174 to
31e3529
Compare
Remove dependency on FormToolkit, ExpandableComposite, and ScrolledForm in ChooseWorkspaceDialog and ChooseWorkspaceWithSettingsDialog. Replace with plain SWT composites and Labels with Unicode triangle characters (U+25B8 ▸ / U+25BE ▾) for the expand/collapse toggle. This improves dialog startup performance by eliminating the Forms overhead: extra decorated composites, global paint/focus listeners, color management, and recursive ScrolledForm reflow on each toggle. The Unicode triangles are from the Geometric Shapes block (Unicode 1.0) and render reliably on Windows, macOS, and Linux system fonts. Also fix layout data mismatch where the path Combo used GridData inside a BorderLayout container (now uses BorderData).
vogella
force-pushed
the
replace-forms-api-workspace-dialogs
branch
from
31e3529 to
d1047a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dependency on FormToolkit, ExpandableComposite, and ScrolledForm in ChooseWorkspaceDialog and ChooseWorkspaceWithSettingsDialog. Replace with plain SWT composites and Labels with Unicode triangle characters (▸/▾) for the expand/collapse toggle.
Benefits: